[PATCH] PPC64: EEH Recovery
John Rose
johnrose at austin.ibm.com
Fri Jan 7 07:59:25 EST 2005
Hi Linas-
Here are a couple of non-substantive comments on your PCI Hotplug patch:
+ /* PHB slots don't have bridges */
+ if (slot->bridge == NULL)
continue;
- }
+
+ /* the PCI device could be the PHB itself */
+ if (slot->bridge == dev)
+ return slot;
The PHB case is handled by the first condition. The second comment
would make more sense if "PHB itself" read "slot itself".
-EXPORT_SYMBOL_GPL(rpaphp_find_hotplug_slot);
I suppose we could also make this static and remove it from rpaphp.h.
Thanks-
John
More information about the Linuxppc64-dev
mailing list