[PATCH] sparse fixes for cpu feature constants

Nathan Lynch nathanl at austin.ibm.com
Tue Jan 4 00:16:24 EST 2005


On Sun, 2005-01-02 at 09:33 +1100, David Gibson wrote:
> On Wed, Dec 29, 2004 at 10:33:26PM -0600, Nathan Lynch wrote:
> >
> > Index: 2.6.10/include/asm-ppc64/cputable.h
> > ===================================================================
> > +++ 2.6.10/include/asm-ppc64/cputable.h	2004-12-30 04:04:09.463979408 +0000
> > @@ -16,6 +16,7 @@
> >  #define __ASM_PPC_CPUTABLE_H
> >  
> >  #include <linux/config.h>
> > +#include <asm/page.h> /* for ASM_CONST */
> 
> Have you double checked that this won't cause a nasty #include loop?
> The CPU constants are used in quite a few places, as is page.h

I think it's ok -- page.h includes the following:

- linux/config.h, which includes linux/autoconf.h

- asm-ppc64/naca.h, which includes asm-ppc64/types.h and
asm-ppc64/systemcfg.h.

So I don't see any way that cputable.h could be pulled in before
ASM_CONST is defined.

Thanks,
Nathan





More information about the Linuxppc64-dev mailing list