[RFC] powerpc: Merge 32/64 cacheflush code

Mark A. Greer mgreer at mvista.com
Wed Dec 21 05:27:49 EST 2005


On Tue, Dec 20, 2005 at 12:06:17PM +1100, David Gibson wrote:
<snip>
> Previously, the ppc32 version of flush_dcache_range() did a writeback
> and invalidate of the given cache lines (dcbf) whereas the ppc64
> version did just a writeback (dcbst).  In general, there's no
> consistent meaning of "flush" as one or the other, so this patch also
> renames the dcache flushing functions less ambiguously.  The new names
> are:
> 
> 	wback_dcache_range() - previously flush_dcache_range() on
> ppc64 and clean_dcache_range() on ppc32
> 
> 	wback_inval_dcache_range() - previously
> flush_inval_dcache_range() on ppc64 and flush_dcache_range on ppc32

I agree about the inconsistent meaning of 'flush' but I find 'wback'
distracting b/c it also refers to a type of cache/cache mode.
It makes me think that there's another set of routines for writethru or
something like that.  I realize the caches are in writeback mode but the
point is that it sends my brain down a different path than what is really
meant.

Could we just define 'flush' to mean "push the cached data/instns back
into memory but not invalidate" and still call them 'flush'?  Or use
'push' or something else that does also refer to a cache mode?

Maybe its just me...

Mark



More information about the Linuxppc64-dev mailing list