[RFC] powerpc: Merge 32/64 cacheflush code

Kumar Gala galak at kernel.crashing.org
Wed Dec 21 01:00:41 EST 2005


On Dec 19, 2005, at 5:54 PM, David Gibson wrote:

> On Mon, Dec 19, 2005 at 09:30:37AM -0600, Kumar Gala wrote:
>>
>> On Dec 18, 2005, at 11:44 PM, David Gibson wrote:
>>
>>> Paulus et al, I think the patch below is roughly the right way to  
>>> go,
>>> but it needs much more review and testing (at present it's been
>>> cursorily tested on ppc64 pSeries only).
>>>
>>> This patch merges the cache flushing code for 32 and 64 bit powerpc
>>> machines.  This means the ppc64_caches mechanism for determining
>>> correct cache sizes at runtime is ported to 32-bit, and is thus
>>> renamed as 'powerpc_caches'.  The merged cache flushing functions go
>>> in new file arch/powerpc/kernel/cache.S.
>>
>> Why dont we just use the cache line information in the cputable?  Why
>> the introduction of this new powerpc_caches structure?
>
> Because the device tree can override the information from the
> cputable.  Oh, and the structure is only new for ppc32.

If the device tree overrides the cputable should we not believe it?   
I guess I dont understand why we need the same information in  
multiple places?

- kumar



More information about the Linuxppc64-dev mailing list