[RFC PATCH 1/3] move hvc_console headers around

[Milton Miller]

On Dec 17, 2005, at 5:38 AM, arnd at arndb.de wrote:

> On Sünnavend 17 Dezember 2005 06:02, Milton Miller wrote:
>>
>> On Dec 16, 2005, at 6:10 PM, Arnd Bergmann wrote:
>>>   */
>>>  #define HVC_ALLOC_TTY_ADAPTERS	8
>>
>> This patch misses the requested cleanup of moving this define for the
>> total number of tty devices registered to the .h
>
> What's the point of moving it to a header file if no other file needs
> to know the value?

That argument applies equally well to both defines.


>> and sanitizing that  against the number of consoles.
>
>> Currently we can recoginse the first 16 devices in the device tree and
>> choose any one of them as the kernel console, but we only allow the
>> first 8 to have a tty (and hence allow /dev/console to be opened).
>
> I understood the problem, but did not want to make functional changes 
> to
> the hvc_vio driver in my cleanup of the cleanup. What do you suggest as
> a fix for this? Should the number be limited at all?

Since one controlls static allocations and the other a runtime 
allocation having them visable makes sense.

I would propose that since no one has aparently complained, that 8 
would be enough for both.

That could be a nieve position.  Perhaps the change should be a 
seperate patch.

milton