[PATCH] Make parport_pc use check_legacy_ioport()
Benjamin Herrenschmidt
benh at kernel.crashing.org
Sun Dec 11 10:49:48 EST 2005
> I mean that smsc_check() and winbond_check() functions in parport_pc.c
> will still crash the machine, surely?
Oh, I haven't seen these... Dammit, can we have a single driver written
on x86 that isn't a pile of horse shit ?
> It's more than just whether the device exists or not. For some devices,
> part of the configuration is done in the SuperIO registers. In
> particular, most of the UARTs on these chips can go up to 460800 or
> 921600 baud, but those modes need to be enabled in the SuperIO
> (generally not in the registers of the UART itself, except in the
> NatSemi case where it _also_ needs to be enabled in the SuperIO regs to
> let you have access to that bank of UART regs).
>
> I think IrDA ports do FIR mode in a similar fashion too.
>
> But what I mean by the above quote is that for platforms where we _do_
> have actual control of the hardware and we want to poke at superio, it
> should be a superio pnp/bus driver rather than a scattering of superio
> probes through various other (8250/parport/irda/floppy) places.
Just put that code in #ifndef CONFIG_PPC then
Ben.
More information about the Linuxppc64-dev
mailing list