[PATCH] updated: Minor numa memory code cleanup

[Michael Ellerman]

On Wed, 30 Nov 2005 16:49, Mike Kravetz wrote:
> On Wed, Nov 30, 2005 at 04:33:36PM -0600, Michael Ellerman wrote:
> > On Wed, 30 Nov 2005 15:47, Mike Kravetz wrote:
> > > Here is an updated version of the patch that panics if no memory is
> > > found as Nathan suggested.  I'm still concerned that panic strings
> > > (not just the one added here) at this stage of booting do not show
> > > up on my system.  But, that is an issue separate from this patch.
> >
> > You probably need to enable one of the EARLY_DEBUG_INIT macros, in
> > arch/powerpc/kernel/setup_64.c.
>
> I was thinking more about debugging production systems in the field
> where we may not have the luxury of booting a debug kernel.

Sure, the nature of early debug is it's trying to tap things that may or may 
not be around and/or configured - so it's not enabled be default because it 
will cause some machines to not boot. That's just the way it is.

> Seem to recall a situation in the past where someone ran into a
> problem in numa.c that called panic.  Didn't get the panic message
> displayed on the console.  Had them enable xmon, and dig the panic
> message out of the console buffer.  Sure would be nice if we could
> get all those early catastrophic failure messages to the console.

Hmm, I'd have to check the code, but if xmon is working then you should be 
able to see the panic.

If it's a real problem you could look at generalising init/main.c's 
panic_later mechanism, which delays a panic until after the console is 
initialised?

cheers

-- 
Michael Ellerman
IBM OzLabs

email: michael:ellerman.id.au
inmsg: mpe:jabber.org
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20051130/81a6a7a7/attachment.pgp