[PATCH 2/12] ppc64: Fixup __after_prom_start to use phys address returned from prom_init()

[Michael Ellerman]

On Tue, 30 Aug 2005 15:47, Milton D. Miller II wrote:
> Michael Ellerman wrote:
> >  /*
> > - * At this point, r3 contains the physical address we are running at,
> > - * returned by prom_init()
> > + * At this point, r30 contains the physical address of __start, returned
> > + * by prom_init()
> >   */
>
> 1) its not necessarly from prom_init
>
> 2) its not returned, its a parameter on the new call.

You're right, I was just updating the comment per my changes, I didn't check 
if it was *actually correct* :D

> I think this code would be clearer if we moved the call to prom_init
> to be the straight path (reversed the sense of the initial compare to
> r5) and have a "we skip to after the trap branch" for the kexec/other
> non-prom callback bootloader case.
>
> Somewhere I have a patch to do that, buried in a tree mixed with
> something else most likely.

Yeah you're right that probably would be cleaner. If you can't find that patch 
anytime soon I'll do it myself when I get to it next.

cheers

-- 
Michael Ellerman
IBM OzLabs

email: michael:ellerman.id.au
inmsg: mpe:jabber.org
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20050830/73bbe062/attachment.pgp