[-mm UPDATE PATCH 13/32] ppc64: replace schedule_timeout() with msleep_interruptible()

Nishanth Aravamudan nacc at us.ibm.com
Wed Aug 17 15:51:36 EST 2005


On 16.08.2005 [17:30:42 -0700], Andrew Morton wrote:
> Nishanth Aravamudan <nacc at us.ibm.com> wrote:
> >
> > On 16.08.2005 [13:30:01 +0200], Arnd Bergmann wrote:
> >  > On Maandag 15 August 2005 20:15, Nishanth Aravamudan wrote:
> >  > > Description: Use schedule_timeout_interruptible() instead of
> >  > > set_current_state()/schedule_timeout() to reduce kernel size.
> >  > 
> >  > Shouldn't these use msleep_interruptible() instead?
> > 
> >  Yes, you are right. I had forgotten to get on that after my -KJ patches
> >  which affected these files. Does the following patch look ok/better?
> >  This should avoid the load average increase issues the ppc64 maintainers
> >  (rightly) had with my older -KJ patches.
> > 
> >  Thanks,
> >  Nish
> > 
> > 
> > 
> >  Description: Use msleep_interruptible() instead of schedule_timeout() in
> >  ppc64-specific code to cleanup/simplify the sleeping logic.
> 
> Really I'd prefer not to include this patch at this time.  It's a separate
> thing from the simple mechanistic convert-to-schedule_timeout_interruptible
> patches.  This patch requires more thought and review.
> 
> So hm.  I'll just drop 13/32 and handle this patch as a separate thing.

Eep, sorry about that Andrew. I just replied-to-all. I didn't intend for
you to pull this in with the other 31 patches, as you are correct, it
should be reviewed. I think it should go in via the ppc64 maintainers.

Thanks,
Nish



More information about the Linuxppc64-dev mailing list