[PATCH] iSeries build with newer assemblers and compilers

David Gibson david at gibson.dropbear.id.au
Mon Aug 15 18:07:50 EST 2005


On Mon, Aug 15, 2005 at 10:00:35AM +0200, Christoph Hellwig wrote:
> On Mon, Aug 15, 2005 at 05:51:15PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > This patch makes iSeries build with the newer assemblers and compilers.
> > We had a hack to allow us to move xLparMap out of head.S but that
> > required a horrible bit of inline assembler in LparData.c.  When I
> > upgraded Debian unstable in order to use their biarch compiler, even that
> > hack broke.  This patch works around the whole compiler/assembler mess by
> > patching the address we care about into the vmlinux after it is built.
> 
> Why don't you move it back to head.S?  Sure it was ugly, but the
> previous and new workaround are even worse.

I disagree.  Apart from the nasty fixed address, having it in head.S
means the VSID constants have to be hard coded.  In C, those can be
computed using macros, which means it's much less likely to break if
we change the VSID scrambling functions again.

Having the LparMap sitting there also blocks a bunch of rearrangements
and cleanups I want to do in head.S (currently in paulus' queue).

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/people/dgibson



More information about the Linuxppc64-dev mailing list