[RFC/PATCH] ppc64: Move ppc64_enable_pmcs() logic into a ppc_md function

Paul Mackerras paulus at samba.org
Mon Aug 8 15:39:11 EST 2005


Michael Ellerman writes:

> This patch adds an enable_pmc entry to the ppc_md structure, and moves code
> from arch/ppc64/kerne/sysfs.c into the various platform files. There should be
> no functional changes.

Not a bad idea, but why don't you make separate functions for
bare-metal and hypervisor versions of pSeries_enable_pmcs, and set
ppc_md.enable_pmcs to one or the other as appropriate?

Paul.



More information about the Linuxppc64-dev mailing list