[RFC/PATCH] numa: distinguish associativity domain from node id

Nathan Lynch ntl at pobox.com
Thu Apr 7 06:06:01 EST 2005


Hi Dave

On Wed, Apr 06, 2005 at 12:08:31PM -0700, Dave Hansen wrote:
> One minor nit:
> 
> 	static int of_node_to_nid(struct device_node *dn)
> 
> That sounds to me like a conversion function, but it also does some
> setup, like setting the nodes online.  I might separate the conversion
> function (the read-only part) from the setup one that writes part of the
> configuration.

Yeah, that's a little sneaky and non-obvious, will fix.  Thanks for
taking a look.

Nathan



More information about the Linuxppc64-dev mailing list