[PATCH] dynamic addition of PCI Host bridges

Linas Vepstas linas at austin.ibm.com
Fri Sep 17 06:34:37 EST 2004


On Wed, Sep 15, 2004 at 05:21:00PM -0500, John Rose was heard to remark:
> The following patch implements the ppc64-specific bits for dynamic (DLPAR)
> addition of PCI Host Bridges.  The entry point for this operation is
> init_phb_dynamic(), which will be called by the RPA DLPAR driver.  
> 
> Comments welcome!

one nit-picky comment, one question.

nit-pick:
I noticed that pci_alloc_pci_controller() and pci_alloc_phb_dynamic()
are almost identical, except that one has the flag is_dynamic=1, 
and the other not.  why not merge them into one, and just pass
"is_dynamic" as a flag?

question:
I presume 'remove" is in the works?
Is part of the difficulty of implementing remove that
pci_alloc_pci_controller() calls alloc_bootmem(), which makes 
freeing these things kind-of tricky? (i.e. since pci is getting
set up before init_mem is done?)

--linas




More information about the Linuxppc64-dev mailing list