[Fwd: [RFC][PATCH] flush_hash_page]
Dave Hansen
haveblue at us.ibm.com
Tue Sep 14 03:08:29 EST 2004
On Mon, 2004-09-13 at 08:56, Joel Schopp wrote:
> Resending since list was down last time I sent it.
> ---------------------------------------------------
>
> I'm very new to the ppc64 memory management code, please forgive my
> ignorance. I need to be able to use flush_hash_page on arbitrary ptes
> for memory remove. There is a comment in flush_hash_page about not
> supporting large ptes. It looks like most of that work has already been
> done, and all that is needed is the following patch. Am I missing
> something?
>
________________________________________________________________________
> + if (cur_cpu_spec->cpu_features & CPU_FTR_16M_PAGE)
> + large = 1;
> +
First of all, if you do that, doesn't it assume that all ptes that are
passed in are large pages? I don't think that's correct.
Also, think about how huge pages are implemented in Linux. Do huge
pages really even get Linux ptes, or just pmds that act like ptes?
That reminds me. Anton, I don't see ppc64 setting up the Linux
pagetable for the kernel mappings anywhere. Did I just miss them?
-- Dave
More information about the Linuxppc64-dev
mailing list