[Fwd: [RFC][PATCH] flush_hash_page]

Olof Johansson olof at austin.ibm.com
Tue Sep 14 03:20:08 EST 2004


Joel Schopp wrote:
> Resending since list was down last time I sent it.
> ---------------------------------------------------
> 
> I'm very new to the ppc64 memory management code, please forgive my
> ignorance.  I need to be able to use flush_hash_page on arbitrary ptes
> for memory remove.  There is a comment in flush_hash_page about not
> supporting large ptes.  It looks like most of that work has already been
> done, and all that is needed is the following patch.  Am I missing
> something?

I think you might be missing something. You just changed the function to 
assume that all pages are large pages if the CPU supports them. This is 
true for kernel pages, but not for user ones. As a result, the wrong 
hash function will/might be used.

You need to know if the page you're looking to flush is large or not. 
Right now there's no way to pass that down, thus the comment in the 
function.


-Olof



More information about the Linuxppc64-dev mailing list