[PATCH 1/1] build modular usb isd200 with modular ide

Doug Maxey dwm at austin.ibm.com
Wed Oct 27 04:05:12 EST 2004


On Tue, 26 Oct 2004 12:05:29 +1000, Paul Mackerras wrote:
>For Linux or some other OS?

Linux for little over a year, 2.6 for about 3 months, some _other_ OS for
several years.

>
>> device vs BE host.  The transfers are done as a 16 bit quantity, PIO.
>> And yes, I understand, "we have always done it this way".  Works well
>> when you only have to deal with single arch.
>
>No, we haven't always done it this way on PPC. :)  Various different
>ways have been tried over the years and this is the only way that
>doesn't suck.
>
>> Possibly I am not making point very well, that one is preserving the
>> correct byte order and let the structures reflect to native location.
>
>I can't parse that sentence unambiguously...

s/to native location/the normalized (for the host) layout/

>
>> Strings get swapped, 16, 32, and 64 bit fields likewise.  I just missed the 
>> LE order that is is being preserved for *some* few fields only.
>
>Strings shouldn't get swapped, or at least, strings should only need
>to be swapped on a BE platform if they also need to be swapped on an
>LE platform.
>
>> There is not a single reference to byte field in the ATA spec for
>> IDENTIFY DEVICE.  It just happens that some of the fields are 8 bits long. Or 
>> 32 or 64.
>
>And your point is...  ?

To me, and I do seem to be in the minority, it seems that normalizing the 
entire bytestream is the right thing (tm).  But I can see the point that 
leaving certain parts non-normalized is cheaper.

It was my mistake missing the use of the char fields.  GIITD.  In any
event, with 2.6.10-rc1 the problem seems to be solved in spite of my
meddling. :-)

++doug






More information about the Linuxppc64-dev mailing list