cond_syscall() and new ABI.

[Arnd Bergmann]

On Dinsdag 12 Oktober 2004 21:08, David Woodhouse wrote:
> On Tue, 2004-10-12 at 20:43 +0200, Arnd Bergmann wrote:
> > A better solution IMHO would be to include the right headers from sys.c
> > and have
> > 
> > #define cond_syscall(x) typeof(x) (x) __attribute__((weak,alias("sys_ni_syscall")));
> 
> That's true in theory, yes -- not that I can see any way that having the
> 'correct' prototype will actually make a difference in practice.

Right, my point was mostly about having an implementation that is less
surprising to the reader, not about correctness. It might actually
become a bug as soon as someone tries to build the kernel with
a compiler that does inter-module analysis, but that's not likely
to happen soon.

	Arnd <><
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20041013/d033fef2/attachment.pgp