Gothic horrors in pci_dn.c

Benjamin Herrenschmidt benh at kernel.crashing.org
Fri Oct 8 12:27:07 EST 2004


On Thu, 2004-10-07 at 18:30, Benjamin Herrenschmidt wrote:

> +		/* If we are a PCI bridge, go down */
> +		if (dn->child && (class >> 8) == PCI_CLASS_BRIDGE_PCI &&
> +		    (class >> 8) == PCI_CLASS_BRIDGE_CARDBUS)
> +			/* Depth first...do children */
> +			nextdn = dn->child;

Of course, that should have been

+		/* If we are a PCI bridge, go down */
+		if (dn->child && ((class >> 8) == PCI_CLASS_BRIDGE_PCI ||
+				  (class >> 8) == PCI_CLASS_BRIDGE_CARDBUS))
+			/* Depth first...do children */
+			nextdn = dn->child;

Ben.





More information about the Linuxppc64-dev mailing list