[PATCH] PPC64: EEH Recovery
benh at kernel.crashing.org
Tue Nov 23 09:12:36 EST 2004
> I'll double-check, I was under the impression that the unregister
> happened, and I was just avodiing the final free(). Maybe I'm sorely
In fact, I don't think there is much problem keeping the pci_dev
structure around if it has been unlinked from the bus & other kobject
hierarchy, but make sure of that ... It will ultimately go away though.
> > > - if (!dev)
> > > + if (!dev)
> > > return val;
> > >
> > > dn = pci_device_to_OF_node(dev);
> > adding trailing white space. tsk tsk
> This comes from the nasty habit of the linux coding style not using
> braces for single-line if's written as double-lines.
"nasty habit" ... I there anything in linux you won't qualify of "nasty
habits" one day ? :) I hate braces for one lines. they are ugly.
> So if one
> inserts braces during debug, one has to remember to remove
> them afterwards, which can lead to inadvertent whitespace.
You should always do a dirdiff pass to review your patches, that catches
these things, and sometimes others...
> Personally, I'd like to get the linux kernel coding style changed,
> this *is* an issue I do care about, a lot. However, I figure that
> would be an unpleasent battle. Oh well.
Get the linux kernel coding style changed ? wow ! good luck :) You won't
win a battle whose entire point it to create uglyness ;)
> ? Don't understand the question. PCI devices are arranged in a tree.
> One of the cards I test with has a bridge and several devices under it.
> So one has to walk the whole tree, which might be arbitrarily deep, to
> get to all of the devices.
Then attach your structures to the device-tree instead. No need to
duplicate the structure.
More information about the Linuxppc64-dev