[PATCH] PPC64 Poor assembly coding style

Segher Boessenkool segher at kernel.crashing.org
Wed Nov 10 23:59:42 EST 2004

On 10-nov-04, at 0:56, Benjamin Herrenschmidt wrote:

> On Wed, 2004-11-10 at 09:52 +1030, Alan Modra wrote:
>> On Tue, Nov 09, 2004 at 05:03:13PM -0600, Doug Maxey wrote:
>>> entry.S:100: Error: operand out of range (268 is not between 0 and 
>>> 31)
>>> entry.S:100: Error: missing operand
>> [snip]
>>>     100         cmpli   0,r0,NR_syscalls
>> OK, this one is Segher's patch, now reverted, making the L operand on
>> cmpli non-optional.
>> Any of "cmpli cr,l,r,imm", "cmplwi cr,r,imm", or "cmpldi cr,r,imm" 
>> will
>> be accepted by the assembler.
> Yah, Segher seem to have a deep love with the idea of pushing gas
> changes that break pretty much everything out there ;)

It's not a "change", it's a bugfix.  And it only is reverted because
it also changed tlbie syntax to conform to the architecture 
specification --
tat unfortunately is directly contradicted by the PEM.  Will fix, but 
lazy, so you have some time to fix all your bugs before it's too late 


More information about the Linuxppc64-dev mailing list