[PATCH] iommu fixes, round 3

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Nov 4 09:51:47 EST 2004


On Wed, 2004-11-03 at 16:50 -0600, John Rose wrote:
> On Wed, 2004-11-03 at 16:15, Benjamin Herrenschmidt wrote:
> <snip>
> > And what will happen the day I remove the iommu table pointer
> > from the struct device-node anyway ?
> 
> This would break the current table creation and management scheme, so
> some reworking would have to be done anyway.  As for cleaning up struct
> device_node, you're preaching to the choir.  How will the tables be
> associated with devices in the new case?

Some structure attached to the device, but not the device-node. But it's
not there yet anyway, it's a long term goal.

> > If your interface to userland relies on that, then it's broken and will
> > have to be reworked :( 
> 
> User-space DLPAR stuff doesn't care about these tables, or at what point
> they're freed, if that's what you mean.  Thanks for looking at the
> patch, I'll take reluctant acceptance over nothing :)

Hehe, well, we need to fix the problem for now anyway.

Ben.





More information about the Linuxppc64-dev mailing list