[PATCH] iommu fixes, round 3
John Rose
johnrose at austin.ibm.com
Thu Nov 4 02:50:20 EST 2004
> > - Creates of_cleanup_node(), which will directly precede the dynamic removal of
> > any device node
>
> Hrm... one thing I'm still annoyed with is that you are still calling
> of_cleanup_node() from within of_remove_node(). That call should be
> moved to the caller.
:) Respectfully, I still disagree. The caller is a procfs-specific function
related to an interface that we're hoping to deprecate soon. We want this to
happen any time a node is removed, not anytime a node is removed using
interface so-and-so.
To me, it makes sense to put this here since of_add_node() calls
of_finish_node_dynamic(), which creates the table.
John
More information about the Linuxppc64-dev
mailing list