[PATCH] PPC64 iSeries virtual ethernet transmit errors

[Stephen Rothwell]

Hi Olaf,

On Wed, 19 May 2004 14:42:11 +0200 Olaf Hering <olh at suse.de> wrote:
>
> Here is another one, no spin_unlock in the error path:
>
>
> --- linux-2.6.5/drivers/net/iseries_veth.c        2004-05-19 14:24:21.000000000 +0200
> +++ linux-2.6.5/drivers/net/iseries_veth.c   2004-05-19 14:32:39.000000000 +0200
> @@ -994,6 +994,7 @@ static int veth_start_xmit(struct sk_buf
>                         veth_error("%s: Tx while skb was pending!\n",
>                                    dev->name);
>                         dev_kfree_skb(skb);
> +                       spin_unlock_irqrestore(&port->pending_gate, flags);
>                         return 1;
>                 }

Good catch - this has an impact on a bug we have flagged internally.

Linus, Andrew, this should also go into your trees.
--
Cheers,
Stephen Rothwell                    sfr at au.ibm.com
IBM OzLabs Linux Technology Centre

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/