[PATCH] PPC64 iSeries virtual ethernet transmit errors

Stephen Rothwell sfr at au1.ibm.com
Wed May 19 18:05:16 EST 2004

Hi Olaf,

This patch stops the iseries_veth driver trying to send every packet to
too many logical partitions.  Consequently, the number of transmit
errors falls to (about) zero from a very large number.  This should
also improve performance a bit as the driver is no longer doing 31 extra
skb_clone()s and skb_free()s for each packet ...

Linus, Andrew, I would be grateful if this could go into your trees as well.

Stephen Rothwell                    sfr at au.ibm.com
IBM OzLabs Linux Technology Centre

diff -ruN 2.6.6-bk3/drivers/net/iseries_veth.c 2.6.6-bk3.txerr/drivers/net/iseries_veth.c
--- 2.6.6-bk3/drivers/net/iseries_veth.c	2004-05-10 15:31:17.000000000 +1000
+++ 2.6.6-bk3.txerr/drivers/net/iseries_veth.c	2004-05-19 17:38:18.000000000 +1000
@@ -940,7 +940,7 @@
 	for (i = 0; i < HVMAXARCHITECTEDLPS; i++) {
 		struct sk_buff *clone;

-		if (! lpmask & (1<<i))
+		if ((lpmask & (1 << i)) == 0)

 		clone = skb_clone(skb, GFP_ATOMIC);

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list