hvconsole.c : possible problem

[Hollis Blanchard]

On Apr 28, 2004, at 12:05 AM, Benjamin Herrenschmidt wrote:
>  - The whole wait_for_packet() is completely synchronous (doesn't
> schedule), that doesn't sound very good.

Can't do schedule(). wait_for_packet() is called at init time, as a
console_initcall, to handshake with the service processor.
console_init() is called under lock_kernel()...
	bad: scheduling while atomic!

I'm sure other code is in this same position. Is it a good idea to do
something like
	if (in_atomic())
		usleep()
	else
		schedule()
?

--
Hollis Blanchard
IBM Linux Technology Center


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/