[PATCH] fix KDB backtrace for ppc64

linas at austin.ibm.com linas at austin.ibm.com
Thu May 6 04:20:42 EST 2004


On Wed, May 05, 2004 at 07:16:47PM +0500, Ananth N Mavinakayanahalli wrote:
> @@ -200,25 +196,49 @@ kdba_bt_stack_ppc(struct pt_regs *regs,
> +		if (!flag && (task_curr(p))) {
> +
> +			lr = regs->link;

Its not obvious that regs might not be a null pointer.  Code
higher up tries to make sure that regs is set to something,
but its not clear that every branch is correctly handled.

Other than that, the patch looks reasonable.

--linas


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list