[PATCH] PCI PHB unit id detection interface change

Anton Blanchard anton at samba.org
Wed Jun 16 06:48:58 EST 2004

Hi Linas,

> I'm looking for sanity-check/review of the following patch.
> Turns out ath the kernel has been using a deprecated firmware
> interface for discovring the PCI PHB Unit Id's.   The PHN Unit
> ID's are used for a variety of PCI operations.  The patch
> below is a change to use the recommended API.


> Its been tested on one-each of power3,4,and 5 boxes; however,
> given that its an API change,  I have some concern that someone
> might get broken by this.  Please review.

A few suggestions on top of Olafs comments.

> +void init_pci_config_tokens (void)

Can be marked static.

> +#define NEW_STYLE_BUIDS

We are going to need to test this rather extensively, so once that is
done we dont need to keep the old broken version.

> +/* From pSeries_pci.h */
> +extern void init_pci_config_tokens (void);
> +extern unsigned long get_phb_buid (struct device_node *);

Prototypes should into a .h file, Ive been bitten by throwing prototypes
into .c files before.


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list