[lhcs-devel] Re: [RFC] don't create cpu/online sysfs file

[Dave Hansen]

On Mon, 2004-06-07 at 10:22, Ashok Raj wrote:
> On Mon, Jun 07, 2004 at 09:41:49AM -0700, Dave Hansen wrote:
> > On Mon, 2004-06-07 at 07:08, Ashok Raj wrote:plugging.
> > > +		if (systemcfg->platform == PLATFORM_PSERIES_LPAR)
> > > +			cpu->no_control=1;
> >
> > That condition is also inverted.  Should read:
> >
> > if (systemcfg->platform != PLATFORM_PSERIES_LPAR)
> > 	cpu->no_control = 1;
>
> Good catch...I knew i mentioned untested :-)
>
> fixed patch attached...

The smallest of nitpicks:

	cpu->no_control=1;

needs to be

	cpu->no_control = 1;

Would you like to submit this now?

-- Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: p00002_cpu_control_file.patch
Type: text/x-patch
Size: 2644 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20040607/2ab96372/attachment.bin