[PATCH] ISA OFDT node refcount fix

John Rose johnrose at austin.ibm.com
Tue Jul 27 08:57:04 EST 2004


The patch below moves a misplaced of_node_put().  In the existing code, the
node in question is used just after its refcount is decremented.  Please apply.

Thanks-
John

Signed-off-by:  John Rose <johnrose at austin.ibm.com>

diff -Nru a/arch/ppc64/kernel/pSeries_pci.c b/arch/ppc64/kernel/pSeries_pci.c
--- a/arch/ppc64/kernel/pSeries_pci.c	Mon Jul 26 17:47:44 2004
+++ b/arch/ppc64/kernel/pSeries_pci.c	Mon Jul 26 17:47:44 2004
@@ -284,10 +284,10 @@
 				isa_dn = of_find_node_by_type(NULL, "isa");
 				if (isa_dn) {
 					isa_io_base = pci_io_base;
-					of_node_put(isa_dn);
 					pci_process_ISA_OF_ranges(isa_dn,
 						hose->io_base_phys,
 						hose->io_base_virt);
+					of_node_put(isa_dn);
                                         /* Allow all IO */
                                         io_page_mask = -1;
 				}


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/




More information about the Linuxppc64-dev mailing list