[PATCH] 2.6 ppc64 RTAS: use dynamic buffer size

Linas Vepstas linas at austin.ibm.com
Sat Jul 24 09:58:59 EST 2004


Yes, that will work too.

--linas

On Fri, Jul 23, 2004 at 04:41:56PM -0400, Paul Mackerras was heard to remark:
> Linas Vepstas writes:
>
> > heh. I wondered if anyone would notice.. Yes, put this line back to
> > where it used to be.
> >
> > Silly me, for a moment there, I was thinking that firmware was
> > looking at this value and so I was desperately trying to make sure
> > it was right; I need'nt have worried. I realized this right after I
> > hit "send" on email ...
> >
> > > The rest of it looks fine. If you agree that this hunk can go,
> > > I'll send the rest of it upstream.
> >
> > Yep, Just make sure that 'rets' is set somewhere in there, anywhere
> > (e.g. put this line back to how it used to be).
>
> In fact I wasn't quite correct, since the next line dereferenced
> err_args.rets. However, it isn't necessary to set either err_args.rets
> or rtas.args.rets in that function, since neither enter_rtas() nor
> RTAS itself look at that field.

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list