[PATCH] set tbl->it_type to TCE_PCI in iommu code

Ananth N Mavinakayanahalli ananth at in.ibm.com
Fri Jul 23 15:44:08 EST 2004


On Thu, Jul 22, 2004 at 03:00:09PM -0400, Paul Mackerras wrote:

Hi Paul,

> > Here is a patch that sets struct iommu_table->it_type to TCE_PCI in
> > pSeries_iommu.c. Please apply
>
> This certainly looks like a good thing to do.  To help me explain it
> better to Andrew Morton, could you tell me whether this fixes an
> actual bug (and if so, what bug)?  Or is it just for code cleanness,
> or to help debugging?

I noticed that the it_type was not being set when updating the old
tce_table code in ppc64 kdb to use the changed iommu structs. This
is just for code completeness (and it is updated in iSeries_iommu.c,
but was somehow missed in pSeries_iommu.c).


Thanks,
Ananth


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list