[PATCH] 2.6 PPC64: Reduce rtas spamming
Paul Mackerras
paulus at samba.org
Fri Jul 23 05:12:55 EST 2004
Dave Hansen writes:
> On Wed, 2004-07-21 at 11:55, Nathan Fontenot wrote:
> > Would anyone have a problem with moving everything from
> > /proc/ppc64/rtas to sysfs (/sys/firmware/rtas) ? It seems that sysfs
> > is where all these files should live anyway.
>
> Some of them use pretty broken interfaces, and I don't think
> they should be perpetuated. The biggest offender in my mind is
> ppc64/rtas/rmo_buffer. It exports physical addresses so that they
> can be mapped with /dev/mem. I think a more refined interface is
> appropriate here.
First, we won't remove any /proc files from 2.6 that are being used by
applications. That's a job for 2.7. (I think we could remove things
like /proc/ppc64/rtas/poweron though.)
Secondly, we can discuss the rmo_buffer thing if you like, but I'll be
surprised if you can come up with something that doesn't involve
unnecessarily duplicating code. The users of rmo_buffer absolutely
need to know the physical address of the rmo_buffer memory. Given
that, I don't see any good reason for making a device with an mmap
method for mapping the rmo_buffer memory into userspace when we
already have a perfectly good device which we can use for that
purpose, namely /dev/mem.
In other words, you'll need to produce a more sophisticated technical
argument than just "/dev/mem? ugh..". 8-)
Paul.
** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/
More information about the Linuxppc64-dev
mailing list