[PATCH] 2.6 PPC64: Reduce rtas spamming

John H Rose johnrose at us.ibm.com
Thu Jul 22 05:56:45 EST 2004


I know this is the trendy idea, and I don't disagree with it, but keep in
mind that you'll break tools.  Update flash, for example. :)

John

-----------------------
John Rose
pSeries Linux Development
johnrose at austin.ibm.com
Office: 512-838-0298
Tieline: 678-0298

[ Nathan Fontenot <nfont at austin.ibm.com> writes: ]
>
> Greg KH wrote:
> > On Mon, Jul 19, 2004 at 11:52:25AM -0500, Nathan Fontenot wrote:
> >
> >>+   entry = create_proc_entry("ppc64/rtas/rtasmsgs", S_IRUSR, NULL);
> >>+   if (entry)
> >>+         entry->proc_fops = &ppc_rtas_msg_operations;
> >>+
> >
> > Please do not do this in proc. It should be in sysfs (and the side
> > affect of that will be that your code is smaller...)
>
> Agreed, and glad you mentioned it.
>
> Would anyone have a problem with moving everything from
> /proc/ppc64/rtas to sysfs (/sys/firmware/rtas) ? It seems that sysfs
> is where all these files should live anyway.

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list