[PATCH] 2.6 PPC64: Reduce rtas spamming

Nathan Fontenot nfont at austin.ibm.com
Thu Jul 22 04:55:10 EST 2004


Greg KH wrote:
> On Mon, Jul 19, 2004 at 11:52:25AM -0500, Nathan Fontenot wrote:
>
>>+	entry = create_proc_entry("ppc64/rtas/rtasmsgs", S_IRUSR, NULL);
>>+	if (entry)
>>+		entry->proc_fops = &ppc_rtas_msg_operations;
>>+
>
>
> Please do not do this in proc.  It should be in sysfs (and the side
> affect of that will be that your code is smaller...)
>
> thanks,
>
> greg k-h

Agreed, and glad you mentioned it.

Would anyone have a problem with moving everything from /proc/ppc64/rtas
to sysfs (/sys/firmware/rtas) ?  It seems that sysfs is where all these
files should live anyway.

--
Nathan F.

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list