[PATCH] 2.6 PPC64: Reduce rtas spamming

Greg KH greg at kroah.com
Thu Jul 22 03:53:20 EST 2004


On Wed, Jul 21, 2004 at 01:55:10PM -0500, Nathan Fontenot wrote:
> Greg KH wrote:
> >On Mon, Jul 19, 2004 at 11:52:25AM -0500, Nathan Fontenot wrote:
> >
> >>+	entry = create_proc_entry("ppc64/rtas/rtasmsgs", S_IRUSR, NULL);
> >>+	if (entry)
> >>+		entry->proc_fops = &ppc_rtas_msg_operations;
> >>+
> >
> >
> >Please do not do this in proc.  It should be in sysfs (and the side
> >affect of that will be that your code is smaller...)
> >
> >thanks,
> >
> >greg k-h
>
> Agreed, and glad you mentioned it.
>
> Would anyone have a problem with moving everything from /proc/ppc64/rtas
> to sysfs (/sys/firmware/rtas) ?

No objection from me, please do this, it is the proper place for these
files.

thanks,

greg k-h

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list