RFC: Fix (another) bug in rtas logging

[David Gibson]

On Fri, Jul 16, 2004 at 10:44:19AM -0400, Benjamin Herrenschmidt wrote:
>
> On Fri, 2004-07-16 at 02:13, David Gibson wrote:
> > Have I missed anything here?  This bug certainly fixes the crash on
> > boot I've been getting on our p630.
> >
> > The recent patch changing the rtas error logging had a bug.  It can
> > result in rtas_call() attempting to call kmalloc() too early (from
> > setup_arch() before the slab caches are initialized), leading to an
> > oops on boot.
> >
> > I can see no reason that log_error() can't be called with the
> > rtas.lock still held, so this patch avoids race addresses by the
> > original race by simply moving the log_error() call under the lock.
>
> No, log_error can call ppc_md.log_error which can call some nvram
> stuff itself calling RTAS afaik

Ah, yes, good point.

--
David Gibson			| For every complex problem there is a
david AT gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.
http://www.ozlabs.org/people/dgibson

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/