[PATCH] 2.6 PPC64: lockfix for rtas error log (third-times-a-charm?)]

[Greg KH]

On Thu, Jul 01, 2004 at 04:20:50PM -0500, linas at austin.ibm.com wrote:
>
> On Thu, Jul 01, 2004 at 04:15:12PM -0500, Olof Johansson wrote:
> > linas at austin.ibm.com wrote:
> >
> > > +	/* Log the error in the unlikely case that there was one. */
> > > +	if (unlikely(logit)) {
> > > +		buff_copy = kmalloc (RTAS_ERROR_LOG_MAX, GFP_ATOMIC);
> > > +		if (buff_copy) {
> > > +			memcpy (buff_copy, rtas_err_buf, RTAS_ERROR_LOG_MAX);
> > > +		}
> > > +	}
> >
> > This isn't performance critical code, do you really need to hard code
> > unlikely here?
>
> I figured its more of a hint to the human reader than it is to the compiler.
>
> > (also, as Greg said, you have extra whitespace in some places, including
> > after kmallocs and kfrees)
>
> Is this really important enough to gen a new patch? If that's what it
> takes to get the patch accepted, I'll do it ...

Please do.

thanks,

greg k-h

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/