[PATCH][2.6] set up vio_dev's driver field

Hollis Blanchard hollisb at us.ibm.com
Thu Jan 8 08:53:29 EST 2004

On Jan 7, 2004, at 3:19 PM, Linda Xie wrote:
> >Could you test this patch instead?
> I tested your patch. Here are the things I found:
> 1) DLPAR vio_dev removal completed w/o errors from kernel and user
> space:
> BTW, the current vio_unregister_device() code always returns 0

Yes, unfortunately device_unregister doesn't return an error code.

> 2) DLPAR vio_dev addition failed in vio_register_device() because
> device_register(&viodev->device)
> call failed.
> 3) Changes needed in vio_register_device(): It should free viodev
> struct and return NULL
> when device_register() fails.

I guess so. I was thinking that failure to register with the device
layer was non-fatal (the driver could still handle its device), but
that's not true: the driver won't even be notified of the new device.
So I'll make these changes.

Of course the real question is why device_register() failed... I'll try
to find a partition to debug on.

Hollis Blanchard
IBM Linux Technology Center

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list