(resend) [PATCH] (2.6) os-term call upon kernel panic

Mike Strosaker strosake at austin.ibm.com
Fri Feb 27 16:42:08 EST 2004


olof at austin.ibm.com wrote:
> A couple of comments:
>
> * on iSeries, it'll result in an instant reboot, maybe not desirable
> * no support for G5, will result in NULL branch. Panic will panic. :)
> * if the RTAS os-term call for some reason fails (can it?), the system
>   won't reboot since panic_timeout is 0.
>
> Attached patch resolves those issues by not setting ppc_md.panic on pmac
> and iSeries, and only registers the notifier in case it's set. The timeout
> is kept at 180 even though it won't be used on a successful panic on
> pSeries.
>
> I've tried building it, but I didn't test it much.

Thanks for the updates, Olof.  I tested your patch on a p650 LPAR, and
it works well.  It's probably better to keep panic_timeout at 180, as
your patch does, because it's definitely possible for os-term to return.

Thanks,
Mike

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list