[PATCH] ppc64 procfs cleanup

[olof at austin.ibm.com]

On Wed, 25 Feb 2004, John Rose wrote:

> -static inline struct proc_dir_entry * create_flash_pde(const char *filename,
> -					struct file_operations *fops)
> +static struct proc_dir_entry *create_flash_pde(const char *filename,
> +					       struct file_operations *fops)
>
> For my own education, could you explain when it's appropriate to
> inline?  I was under the impression that functions that could be macros
> were good candidates.

Inlining should only be done where taking the additional function call
adds significant overhead and it's called often enough to impact system
performance.

In addition to the binary bloat, inlining makes debugging painful since
the code will be inserted in the caller and following the flow in
disassembly is hard.


-Olof

Olof Johansson                                        Office: 4E002/905
Linux on Power Development                            IBM Systems Group
Email: olof at austin.ibm.com                          Phone: 512-838-9858
All opinions are my own and not those of IBM


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/