[PATCH] ppc64 procfs cleanup

John Rose johnrose at austin.ibm.com
Thu Feb 26 04:21:52 EST 2004

Hi Anton-

>From rtas_flash.c:
+	if (rtas_token("ibm,update-flash-64-and-reboot") ==
+		printk(KERN_ERR "rtas_flash: no firmware flash support\n");
+		return 1;

Can we not add this? :)  The current module init creates the three /proc
files regardless, and handles the case of "function not supported" with
a certain return code upon /proc file read.

This allows the userland tool to distinguish between the error cases of
"You don't have the module compiled in/loaded" and "You don't have the
firmware functionality."

-static inline struct proc_dir_entry * create_flash_pde(const char *filename,
-					struct file_operations *fops)
+static struct proc_dir_entry *create_flash_pde(const char *filename,
+					       struct file_operations *fops)

For my own education, could you explain when it's appropriate to
inline?  I was under the impression that functions that could be macros
were good candidates.


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list