[PATCH] rpadlpar changes for DLPAR VIO devices -- please review

Hollis Blanchard hollisb at us.ibm.com
Wed Feb 25 09:31:13 EST 2004

On Feb 24, 2004, at 3:44 PM, Linda Xie wrote:

> +	if (strstr(drc_name, "-V"))
> +		dn = find_php_slot_vio_node(drc_name);
> +	else
> +		dn = find_php_slot_pci_node(drc_name);

I'm not sure this is safe as a canonical test. Maybe
sprintf("%s-V%i-D%i", ...)? Is this namespace defined and documented
somewhere? I just don't feel comfortable with a two-character test
determining it one way or the other.

Hollis Blanchard
IBM Linux Technology Center

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list