[PATCH] rpaphp driver changes for vio and multifunction cards support-please review

Hollis Blanchard hollisb at us.ibm.com
Wed Feb 25 02:57:19 EST 2004

On Feb 23, 2004, at 9:08 PM, Linda Xie wrote:
> Any comments would be much appreciated.

In register_slot(), what is this code doing?
>         case VIO_DEV:
>             /* create symlink between slot->name and it's uni-address
> */
>             vio_uni_addr = strchr(slot->dn->full_name, '@');
>             if (!vio_uni_addr)
>                 return (1);
>             retval = sysfs_create_link(slot->hotplug_slot->kobj.parent,
>                 &slot->hotplug_slot->kobj,
>                 vio_uni_addr);

Can you show me tree output? I don't know what these sysfs directories
look like. Whatever this symlink is, do we *need* it? If not I'd say
take it out, as userland will start depending on it and then we'll be
stuck with it forever.

Hollis Blanchard
IBM Linux Technology Center

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list