[PATCH] (2.6) put prom.c on a diet

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Feb 18 11:04:06 EST 2004

On Wed, 2004-02-18 at 10:37, Nathan Lynch wrote:
> Hi-
> This patch separates the Open Firmware "client" code which runs early in
> the boot process from code which is used to access and manipulate the
> kernel's copy of the Open Firmware device tree. The former remains in
> prom.c; the latter is placed in a new file, of_devtree.c.
> I tried to be fairly aggressive about pulling everything out of prom.c
> that could conceivably be used during normal system functioning after
> the system has booted.
> This has been compile-tested and booted on a Power4 lpar.  I believe I've
> avoided breaking any builds, please point out anything I've missed.  Feel free
> to suggest a different name for the new file.  Also, please help me get the
> author credits right :)

While you are at it, can you unify the function definition "style" ?

That is replace



int myfunc(...)

Whatever are the respective merits of each version, the "Linux" way
is the second form ;)

The credits are probably scattered all over the place. I'd name paulus
of course, myself, probably dave engebretsen and peter bergner too...


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list