[PATCH] support for Hotplug/DLPAR PCI multifunction cards

Linda Xie lxiep at us.ibm.com
Sat Feb 14 05:00:28 EST 2004

Hollis Blanchard wrote:
> On Feb 13, 2004, at 10:43 AM, Linda Xie wrote:

> I'm still unclear on the requirement to have an "interrupts" property.
> In this patch, all non-PCI devices without interrupts will be treated as
> errors.

They are not treated as errors, the patch just skips some lines that are
not needed for the devices.

  If the new node doesn't have the property, just skip the
> interrupt code (bringing you to what you've called "fixup_pci"). It
> doesn't even have to be a goto: break the interrupt code into its own
> function and then:
>      ints = (unsigned int *) get_property(node, "interrupts", &intlen);
>      if (ints)
>         of_finish_dynamic_interrupts(...)
>     node->phb = parent->phb;
>     regs = (u32 *)get_property(node, "reg", 0);

Because I didn't want to change the "if(!ints)" logic that was there
before. BTW, I think that yours looks better.

Nathan, Any thoughts?

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list