RTAS error logging of EEH errors

[linas at austin.ibm.com]

Please don't push this patch, It'll mess up my patch which I'm sending
out in a few minutes.  Anton, if this still really bugs you, let me know,
I'll fix it.

--linas

On Mon, Feb 02, 2004 at 10:01:44AM -0600, Nathan Fontenot wrote:
> I ended up leaving this on the stack because we call panic() right
> after using the buffer.  The patch below changes this so that the
> buffer is allocated.  If this is preferred let me know and I will
> push the change to Ameslab.
>
> I don't think this should be a statically defined buffer, no sense
> in keeping around a buffer this big that will only be used once
> right before we die.
>
> -Nathan Fontenot
>
> On Sun, 2004-02-01 at 01:36, Anton Blanchard wrote:
> > Hi,
> >
> > I was reviewing patches to send onto Andrew Morton and noticed:
> >
> >                 if (ret == 0 && rets[1] == 1 && rets[0] >= 2) {
> > +                       unsigned char slot_err_buf[RTAS_ERROR_LOG_MAX];
> > +                       unsigned long   slot_err_ret;
> >
> > Thats 2kB on the stack, it really wants to be kmalloced (GFP_ATOMIC
> > since it can be called in interrupt context) or statically defined.
> >
> > Anton
> >
> --


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/