RTAS error logging of EEH errors

Anton Blanchard anton at samba.org
Sun Feb 1 18:36:27 EST 2004


I was reviewing patches to send onto Andrew Morton and noticed:

                if (ret == 0 && rets[1] == 1 && rets[0] >= 2) {
+                       unsigned char slot_err_buf[RTAS_ERROR_LOG_MAX];
+                       unsigned long   slot_err_ret;

Thats 2kB on the stack, it really wants to be kmalloced (GFP_ATOMIC
since it can be called in interrupt context) or statically defined.


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list