[PATCH] log machine check errors

[Jake Moilanen]

On Thu, 26 Aug 2004 15:57:20 +1000
Paul Mackerras <paulus at samba.org> wrote:

> Jake Moilanen writes:
>
> > Somewhere along the line it looks like logging machine check errors
> > never got put in 2.6.  Machine check error logs were one of the main
> > reasons for storing logs to nvram.
> >
> > Here's a forward port of the 2.4 code the Dave Altobelli originally
> > wrote.
> [snip]
>
> > +char mce_data_buf[RTAS_ERROR_LOG_MAX]__page_aligned;
>
> Why is this page-aligned?

The page alignment can probably be taken out.  The reason it was
originally aligned in 2.4, was that this buffer was also used for
check-exception (which we don't have in 2.6 or at least aren't
supporting).  IIRC check-exception expects that the buffer not cross an
LMB.  One way we can guarantee it is to make sure it also doesn't cross
a page boundary, hence the page alignment.

Thanks,
Jake

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/