[PATCH] [KDB] Use proper wrappers for udbg calls in KDB

Paul Mackerras paulus at samba.org
Tue Aug 24 16:40:01 EST 2004


Olof Johansson writes:

>  			if (eip == (kdb_machreg_t)ret_from_except ||
> -			    eip == (kdb_machreg_t)ret_from_syscall_1 /* ||
> -								      eip == (kdb_machreg_t)do_bottom_half_ret */) {
> +			    eip == (kdb_machreg_t)syscall_exit /* ||
> +			    eip == (kdb_machreg_t)do_bottom_half_ret */) {
>  				/* pull exception regs from the stack */
>  				struct pt_regs eregs;

I don't like the exporting of syscall_exit, and I'd much rather see it
look for the exception frame marker on the stack instead of looking at
eip.  Could you (and/or Ananth) do a single patch that does that and
fixes the build breakage please?

Thanks,
Paul.

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list