recent sym2 breakage

[Olaf Hering]

 On Mon, Aug 16, Andrew Morton wrote:

>
> So I'm putting together 2.6.8.1-mm1, which is bigger than Ben Hur and it
> seems that someone broke the sym2 driver, on ppc64 at least.
>
> It runs OK, but a `halt -p' spits nasty messages, then hangs.

sym2 is a bit flaky in 2.6.

Does the vanilla kernel work ok for you? You might need at least this
patch in case of rtas errors:


diff -purNX /suse/olh/kernel/kernel_exclude.txt linux-2.6.8.1.orig/arch/ppc64/kernel/rtas.c linux-2.6.8.1-olh/arch/ppc64/kernel/rtas.c
--- linux-2.6.8.1.orig/arch/ppc64/kernel/rtas.c	2004-08-14 12:54:50.000000000 +0200
+++ linux-2.6.8.1-olh/arch/ppc64/kernel/rtas.c	2004-08-15 19:19:49.000000000 +0200
@@ -31,6 +31,8 @@
 #include <asm/delay.h>
 #include <asm/uaccess.h>

+extern int mem_init_done;
+
 struct flash_block_list_header rtas_firmware_flash_list = {0, NULL};

 struct rtas_t rtas = {
@@ -165,6 +167,7 @@ int rtas_call(int token, int nargs, int

 	/* Log the error in the unlikely case that there was one. */
 	if (unlikely(logit)) {
+		if (mem_init_done)
 		buff_copy = kmalloc(RTAS_ERROR_LOG_MAX, GFP_ATOMIC);
 		if (buff_copy) {
 			memcpy(buff_copy, rtas_err_buf, RTAS_ERROR_LOG_MAX);

--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/